babelfish-for-postgresql / babelfish_extensions / 10599358782

76%

BABEL_5_X_DEV: 76%

Build Type

push

github

Committed by web-flow

Commit Message

Support database level collation for babelfish (#2739)

Currently babelfish supports setting collation at server, column and expression levels. User can only set collation at
database level, if it is same as server level. This commit enables the users to set collation at database level using TSQL
syntax:

CREATE DATABASE <db_name> COLLATE <collation_name>

This will set the collation of expressions, columns of tables of string datatypes as same as database level collation by
default. If any user wants to have a different collation, then they can set it at column or expression level. User can
choose NOT to set collation at database level explicitly. In that case, the database collation will be as same as server
level collation. The identifiers will be using server level collation itself.

We store the database level collation while user creates the database in system catalog. And we update the collation
information for that database when user invokes:

USE <db_name>

We have updated few views, functions, stored_procedures to use correct collation. 

This commit also introduces a new test framework for database level collation. This framework will run all the existing
JDBC tests in a database which has a different collation than server level collation.

Engine side PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#409
Task: BABEL-4953

Authored by: Shameem Ahmed <shmeeh@amazon.com>
Co-authored-by: Dipesh Dhameliya <dddhamel@amazon.com>
Co-authored-by: yashneet vinayak <yashneet@amazon.com>
Co-authored-by: Pranav Jain <pranavjc@amazon.com>
Co-authored-by: Tanzeel Khan <tzlkhan@amazon.com>

Signed-off-by: Dipesh Dhameliya <dddhamel@amazon.com>

Run Details

160 of 174 new or added lines in 14 files covered. (91.95%)

2 existing lines in 2 files now uncovered.

44515 of 60106 relevant lines covered (74.06%)

132964.94 hits per line