babelfish-for-postgresql / babelfish_extensions / 13820962713

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Alter procedure/function will unexpectly delete pg_depend records (#3572)

Backgroud:
In our previous implementation of the ALTER PROCEDURE/FUNCTION feature, we followed these steps to update metadata:

1. Create a new procedure/function
2. Replace the new OID with the old OID in the pg_proc metadata
3. Clean up pg_depend/pg_shdepend records referencing the new OID

Analysis: When creating a new procedure/function (step 1):

1. If the parameter list remains unchanged, the Create new function/procedure api will not insert new tuple but updating the existing tuple and return the old tuple oid. In this case, the old OID and new OID are identical, making the pg_depend records cleanup unnecessary.
2. If the parameter list changed, it missed to do anything about the pg_depend/pg_shdepend records created by the new ID, it'll leave inconsistent tuple in the pg_depend/pg_shdepend database.
The replacing of new OID (step 2) with the old OID is not necessary, since there's no other issues need to be concerned, and it's an over-design.

Fix:
For issue 1: Skip pg_depend records cleanup when old OID equals new OID.
For issue 2: Do not replace the new OID with the old OID, and just delete the pg_depend/pg_shdepend records referencing the old OID

Issue-resolved: BABEL-5601
Signed-off-by: Zhibai Song <szh@amazon.com>

Run Details

11 of 11 new or added lines in 2 files covered. (100.0%)

2 existing lines in 1 file now uncovered.

47310 of 63120 relevant lines covered (74.95%)

188823.42 hits per line