babelfish-for-postgresql / babelfish_extensions / 11054622601

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix protocol violation in USE DB when database name contains multibyte characters (#2841)

When database name contains a character which is multi byte encoded in UTF8 then USE DB with that database name throws protocol error in SQLCMD.
```
-- SQL CMD connection
1> CREATE DATABASE ["龙漫远; 龍漫😃😄漫遠.¢£€¥"]
2> go
1> USE ["龙漫远; 龍漫😃😄漫遠.¢£€¥"]
2> go
SqlState HY000, Protocol error in TDS stream.
```
This does not show up in our JDBC framework since we ignore such notice message and do not flush it to output file.

Length of string in TDS stream should be in UTF-16 characters length and not number of bytes.
Hence replaced strlen() with UTF16 number of chars.


Task: [BABEL-5153]

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

219 existing lines in 6 files now uncovered.

44968 of 60380 relevant lines covered (74.47%)

162783.64 hits per line