babelfish-for-postgresql / babelfish_extensions / 11951324660

75%

Build Type

push

github

Committed by web-flow

Commit Message

Fix handling of UPDATE command when RETURNING clause updates declared variables (#3028)

currently, Any variable being set as part of UPDATE...SET... command is being re-written using RETURNING clause. But there was an issue where any dynamic update on variable was not visible to subsequent statement execution. That issue is fixed with 6be12f1 and this commit aims to fix the same issue when dynamic variables are being updated as part of UPDATE...SET... command. In order to make variables updated dynamically, assignment statement is re-written using sys.pltsql_assign_var(dno, expr). For example,

SET @A+=expr, col=expr2

will be re-written to

SET col=expr2 ... RETURNING sys.pltsql_assign_var(dno, "@var" + cast((expr) as type))

Task: BABEL-5188
Signed-off-by: Dipesh Dhameliya <dddhamel@amazon.com>

Run Details

18 of 34 new or added lines in 1 file covered. (52.94%)

2 existing lines in 1 file now uncovered.

45750 of 61238 relevant lines covered (74.71%)

161697.33 hits per line