babelfish-for-postgresql / babelfish_extensions / 9451272229

76%

BABEL_5_X_DEV: 77%

push

github

Fix valgrind warnings related to source and destination overlap in strcpy in datetime, datetime2 and datetimeoffset related functions (#2649)

In datetime_in_str function, we are unnecessarily using strcpy function which is also causing issues in valgrind as the source and the destination overlap.

This commit removes this unnecessary strcpy call in datetime_in_str function. Also, we can directly send the original input string in clean_input_str() function rather than sending modified_str as we were doing before.

Issues Resolved: BABEL-5034

Signed-off-by: Sai Rohan Basa bsrohan@amazon.com

5 of 5 new or added lines in 3 files covered. (100.0%)

42280 of 57870 relevant lines covered (73.06%)

109592.51 hits per line