babelfish-for-postgresql / babelfish_extensions / 14263102480

76%

BABEL_5_X_DEV: 77%

push

github

Fix float to string conversion for boundary values (#3654)

In #3413 , we added new Cast functions for float to varchar/char conversion . We were using the postgres double_to_shortest_decimal_buf API to convert float to string , which would return special values like Infinity/-Infinity for very big/small values , also we were using rounding logic by multiplication and then dividing the result which could result in overflow, Now we fallback to string formatting using psprintf (postgres flavour of printf) and format specifier to fix the precision.
This change also solves the CONVERT function not working correctly with very small float values .

Issues Resolved: BABEL-5709
Signed-off-by: Nirmit Shah <nirmisha@amazon.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

47741 of 63590 relevant lines covered (75.08%)

237643.32 hits per line