babelfish-for-postgresql / babelfish_extensions / 7536919995

76%

BABEL_5_X_DEV: 77%

push

github

Improvements in handling of Babelfish specific GUC after commit <a class=hub.com/babelfish-for-postgresql/babelfish_extensions/commit/a1a00b3bd00cf3f07d382ecb1219e1799b037676">a1a00b3bd (#2244)

With engine commit a1a00b3bd00cf3f07d382ecb1219e1799b037676, community refactored the code related to GUC
handling and introduced certain optimisation around GUC handling. For example, they have introduced following three
fields for various purpose --

static dlist_head guc_nondef_list;	/* list of variables that have source
									 * different from PGC_S_DEFAULT */
static slist_head guc_stack_list;	/* list of variables that have non-NULL
									 * stack */
static slist_head guc_report_list;	/* list of variables that have the
									 * GUC_NEEDS_REPORT bit set in status */
These all fields are getting updated in engine based on various operations on the GUC. Field guc_nondef_list is to track
non-default value of various GUCs and is updated through helper function set_guc_source(...). Now the logic of Babelfish
GUC handling is somewhat different and was not updated to accommodate these code changes. This resulted in hang
while communicating GUCs with non-default value to parallel worker.

This commit aims to fix that issue by utilising appropriate wrapper around set_guc_source(...) exposed in engine to
update the guc_nondef_list stack appropriately.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#290
Task: BABEL-4668, BABEL-4669, BABEL-4670, BABEL-4671
Signed-off-by: Dipesh Dhameliya <dddhamel@amazon.com>

39366 of 54901 relevant lines covered (71.7%)

57632.07 hits per line