babelfish-for-postgresql / babelfish_extensions / 11460085040

76%

BABEL_5_X_DEV: 77%

push

github

fix for storing the correct object definition in catalog (#3017)

If a procedure contains datatype with brackets around like 'DECLARE @Sql [varchar] (8000)' , the babelfish catalog stores it as 'DECLARE @Sql varchar (8000)' i.e the brackets are not stored properly in catalog.
Also if we add a single line comment before a query(like alter, create query) then while logging the definition of that query from catalog we do not get the single line comment, which is not correct.

RCA: while parsing the query we mutate the parse tree in such a way that it modifies various things from the original string like single line comment, brackets, multi line comments.

Fix: store the original query string before mutation and convert alter to create in case or alter procedure/function( batch level statement) and pass that query string.

Issues Resolved: BABEL-5237, BABEL-5236, BABEL-5140

Signed-off-by: Pranav Jain pranavjc@amazon.com

18 of 18 new or added lines in 1 file covered. (100.0%)

45232 of 60686 relevant lines covered (74.53%)

163240.27 hits per line