babelfish-for-postgresql / babelfish_extensions / 9107848273

76%

BABEL_5_X_DEV: 77%

push

github

Add typmod validation in [VAR]BINARY input function (#2570)

[VAR]BINARY input function does not check if input string is bigger than the
desired typmod. This is problematic as it is possible to insert a binary value
larger than typmod into a column. Although, the issue is not there for normal
inserts into a table as there exists typmod coercion functions for binary and
varbinary datatypes which are always called along with input function to adjust
the value length according to given typmod.

But the issue exists for logical replication and dump/restore in which the value
is coming from a remote server possibly with a different typmod. In these cases
typmod coercion functions are not called so no checks are performed on size of
input value.

To fix the issue, this commit adds a check in the [VAR]BINARY input function to
validate input string with typmod and throw error if the value is larger than typmod
similar to [VAR]CHAR datatypes.

Task: BABEL-4956
Signed-off-by: Rishabh Tanwar <ritanwar@amazon.com>

9 of 9 new or added lines in 1 file covered. (100.0%)

41814 of 57457 relevant lines covered (72.77%)

97675.01 hits per line