babelfish-for-postgresql / babelfish_extensions / 9842798170

76%

BABEL_6_X_DEV: 78%

push

github

Cross-db reference of sys* catalogs with dbo schema (#2679)

Cross-database references to the classic sys* catalogs (e.g. sysobjects, syscolumns, syslogins, etc.), while specifying the dbo schema or omitting the schema (e.g. db..sysobjects notation), should not raise an error. For these 'classic' catalogs, referencing the object in dbo or sys schema should be equivalent.
This fix addresses the following notations which either raised an error or could return an incorrect value:

- mydb.dbo.sysobjects
- .mydb.dbo.sysobjects
- mydb..sysobjects
- .mydb..sysobjects
- .mydb.sys.sysobjects

- .mydb.dbo.mytable (for non-catalog objects)
- .object (for any object in case the executing user has a non-dbo default schema)

Various existing test cases, which were raising an error previously, had to be adjusted for this fix.

Note: when the executing user has a non-dbo default schema, the case of dbname..object still ignores the default schema, but that is outside the scope of this fix (see BABEL-5050).

Issues Resolved : BABEL-5041

Signed-off-by: Rob Verschoor rcv@amazon.com

79 of 82 new or added lines in 3 files covered. (96.34%)

42877 of 58576 relevant lines covered (73.2%)

114174.6 hits per line