babelfish-for-postgresql / babelfish_extensions / 15488942949

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Handling CASE expression when one branch is of decimal/numeric and other branch is of smallmoney/money.  (#3808)

Currently, we treat typmod for smallmoney/money datatype as default which leads to output differences in many cases.

Following are the fixes introduced in this PR :

Introduce typmod handling for smallmoney/money datatype for objects like table/procedure/views/functions/casts and handling their upgrade scenarios.
We are also handling p&s for declared variables, nested case expressions and unions having smallmoney/money as one of it's node.
It also takes case of round vs truncation behaviour around edge cases for fixeddecimal multiplication
Money/smallmoney and Numeric Arithmetic operations - precision and sclae correction and fixing TDS protocol Errors.
T_Param node handling for fixeddecimal dataypes (money and smallmoney) when numeric is another operand.
T_Aggref handling for Sum/Avg for fixeddecimal and other fixed length datatypes when numeric is another operand.
Handing typmod for smallmoney/money in pg catalogs for views metadata and during dump-restore.
Handling money/smallmoney typmod and fixeddecimal typmodin during dump-restore and by-passing typmod while deparsing for ISC check constraint.
Avoiding crashes and wrong results by updating sanity checks and setting intermittent result size appropirately for bigint and fixeddecimal multiplication.

Signed-off-by: Tanya Gupta tanyagp@amazon.com

Cherry-pick PR : #3719
Engine PR : babelfish-for-postgresql/postgresql_modified_for_babelfish#586

Issues Resolved
BABEL-5512, BABEL-5718, BABEL-5889, BABEL-5744, BABEL-5750, BABEL-5755, BABEL-5758, BABEL-5892, BABEL-5893, BABEL-5894, BABEL-5895, BABEL-5896, BABEL-5897, BABEL-5898

Run Details

71 of 84 new or added lines in 6 files covered. (84.52%)

2 existing lines in 2 files now uncovered.

48564 of 64443 relevant lines covered (75.36%)

313199.92 hits per line