babelfish-for-postgresql / babelfish_extensions / 8810946473

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Add upgrade test for LIKE and Use optimisation for Const node for AI collations (#2510)

This commit introduces the upgrade tests for LIKE operator for CI_AI and CS_AI collations. Tests for helper function
sys.remove_accents_internal(...) has also been added by creating dependent objects which invokes sys.remove_accents_internal(...).

This change also updates implementation of sys.remove_accents_internal(...) to have output capacity of maximum of
INT32_MAX or 4 * length of input_string (as 4 is the max number of bytes which can be allocated for a single character
in ICU (https://www.rfc-editor.org/rfc/rfc3629#section-3)).

Also, as we are modifying the left and right nodes of the LIKE operator to FuncExpr, we lose the optimisation in case of
constant prefix in pattern. This commit handles the Const node separately so that we can continue enjoy the
optimisation.

TASK : BABEL-4791
Signed-off-by: Shameem Ahmed <shmeeh@amazon.com>

Run Details

15 of 17 new or added lines in 1 file covered. (88.24%)

1 existing line in 1 file now uncovered.

41139 of 56726 relevant lines covered (72.52%)

65048.74 hits per line