babelfish-for-postgresql / babelfish_extensions / 12366936008

76%

BABEL_5_X_DEV: 77%

push

github

Fix the incorrect string limit when declaring NVARCHAR(Max) (#3153)

Previously, the limit on the max length of NVARCHAR(Max) was 4000, longer characters will be truncated. But
NVARCHAR(MAX) should be capable of handling strings far longer than 4,000 characters. This pr change the limit to
default -1 rather than 4000 to fix this issue, and add test cases to verify.

The issue is the typemod for nvarchar(max) in AS JSON queries is set as 4000, which limits the query length, the
solution is to remove the code setting 4000 and recover typemod from TSQLMaxTypmod to -1 in tds client.

Task: BABEL-5054
Signed-off-by: Chenxiao Wang <chxwang@amazon.com>

2 of 2 new or added lines in 1 file covered. (100.0%)

46606 of 62279 relevant lines covered (74.83%)

168894.14 hits per line