babelfish-for-postgresql / babelfish_extensions / 14936716264

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Adjust precision and scale in Numeric Multiplication and Division. (#3741)

In Babelfish's implementation of numeric operations (multiplication and division), logic for adjustment of precision and scale is incorrect as compared to TSQL.
Changes made to fix the issues:
* The numeric operations (multiplication and division) logic for precision and scale adjustment is corrected as per TSQL documentation.
* Fixed the API tsql_numeric_get_typmod and tds_numeric_get_typmod to give correct typmod for a numeric value.
* Added handling for UDT's and fixed length datatypes in T_var node in resolve_numeric_typmod_from_exp

Issues Resolved
Task: BABEL-5689

Signed-off-by: yashneet vinayak <yashneet@amazon.com>
Co-authored-by: yashneet vinayak <yashneet@amazon.com>

Run Details

379 of 410 new or added lines in 8 files covered. (92.44%)

2 existing lines in 1 file now uncovered.

47811 of 63676 relevant lines covered (75.08%)

262329.59 hits per line