9194007381
76%
BABEL_5_X_DEV: 77%

Ran 22 May 2024 04:11PM UTC

Jobs 1

Files 114

Run time 1min

Badge

Embed ▾

Committed 22 May 2024 03:17PM UTC coverage: 72.819% (-0.004%) from 72.823%

Build # 9194007381

Build Type

push

github

Committed by

web-flow

Commit Message

Fix alter table drop constraint not able to drop some constraints (#2602)

Babelfish was hashing the constraint name for named table constraints. But no hashing was done for unnamed table constraints, unnamed column constraints or named column constraints. On the other hand the constraint name in DROP CONSTRAINT was always hashed without exception. This means we were failing DROP for all constraints which were not hashed during creation.

As a fix, we have removed the hashing step from named table constraints creation, making creation of constraints consistent for Babelfish. This also allows us to remove hashing from DROP CONSTRAINT command.

Not hashing constraint name has one repercussion, Users can now create a PRIMARY KEY/UNIQUE constraint with same name as an existing Index on the same table. This was previously blocked for named table constraints but not for other types of constraints. We could block this in the future in a more complete way.

Issues Resolved: BABEL-2047

Signed-off-by: Tanzeel Khan tzlkhan@amazon.com

Run Details

41851 of 57473 relevant lines covered (72.82%)

103444.17 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
1	91.54	-0.02%	contrib/babelfishpg_tsql/src/pl_handler.c
2	74.29	-0.63%	contrib/babelfishpg_tds/src/backend/tds/tdscomm.c

Jobs

ID	Job ID	Ran	Files	Coverage
1	9194007381.1	22 May 2024 04:11PM UTC	114	72.82	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 9194007381
76%
BABEL_5_X_DEV: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 9194007381

babelfish-for-postgresql / babelfish_extensions / 9194007381 76% BABEL_5_X_DEV: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 9194007381

babelfish-for-postgresql / babelfish_extensions / 9194007381
76%
BABEL_5_X_DEV: 77%

README BADGES
x