babelfish-for-postgresql / babelfish_extensions / 10695603061

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix valgrind warning related to CStringDatum used instead of NameDatum plus some more fixes. (#2906)

This PR fixes multiple valgrind warnings.

Replaced all CStringGetDatum occurrences with NameGetDatum when doing CatalogTupleUpdate or Insert on a name column. NameDatum is always of NAMEDATALEN length and null padded if needed.
Fix string literal to rowversion or timestamp cast warning. Row version is always of fixed length but when we cast string literal to rowversion for a smaller input string, we set the typmod correctly but do not actually blank pad the input string. As a fix we will simply reuse the varbinary/binary handling for string literals for row versions and timestamp, this is possible because row versions and timestamp were getting internally converted to varbinary type.
Make sure string is not empty before accessing its last character in sp_execute_postgresql & sp_addrolemember & sp_droprolemember &sp_rename_internal
In TdsRecvTypeTable we were not initialising all the entries of nulls array. Fixed that.
When logging TVP parameter we simply want to log the name, but we were sending CString as input with a record type which is wrong. To fix it, we will now use CString type for logging TVP name.
Issues Resolved
[BABEL-5104]
[BABEL-5221]
[BABEL-4634]
[BABEL-4644]

Test Scenarios Covered
Following JDBC tests do not throw any error with valgrind now
GRANT_SCHEMA
Test-sp_addrolemember-vu-prepar
Test-sp_addrolemember-vu-verify
Test-sp_addrolemember-vu-cleanu
babel-4475-vu-prepare
babel-4475-vu-verify
babel-4475-vu-cleanup
TestTvp -> with log_statements GUC set to 'all'

Sign Off
Signed-off-by: Tanzeel Khan tzlkhan@amazon.com

Run Details

46 of 50 new or added lines in 10 files covered. (92.0%)

2 existing lines in 2 files now uncovered.

44676 of 60185 relevant lines covered (74.23%)

151115.96 hits per line