babelfish-for-postgresql / babelfish_extensions / 11273659322

76%

BABEL_5_X_DEV: 77%

push

github

Fixed UDT handling for CASE statement when branch expression is of String Datatype. (#3009)

In CASE expression if we use UDT or sysname in any of the branch, there was no handling to find overall common type
and common typmod for CASE statement. For example, 

create type BABEL_CASE_EXPR_TEST_UDT from NVARCHAR(100);
GO

SELECT 
CASE 2
   WHEN 1 THEN 'abc'
   WHEN 2 THEN CAST('char' AS BABEL_CASE_EXPR_TEST_UDT)
END AS RESULT
GO

output:

Msg 8152, Level 16, State 1, Server BABELFISH, Line 1
value too long for type character varying(3)

Expected output:

nvarchar
char

Changes made to fix the issues - 

We added handling for UDT and sysname for CASE Expression. While finding common type of CASE Expression, we
checked if the following branch is a UDT or not, if yes then find the immediate base_type of UDT and find the TSQL
precedence according to the immediate base_type. If the branch if of type SYSNAME then we directly assign varchar as
datatype for that branch. While finding the common_typmod of CASE Expression, We checked if the branch is a UDT or
not, if yes then find the typmod of the base_type using getBaseTypeAndTypmod().If one of the branch is
of type SYSNAME then set typmod as SYSNAME_TYPMOD (i.e. 128).

Task: BABEL-5103, BABEL-4332
Signed-off-by: yashneet vinayak <yashneet@amazon.com>

34 of 35 new or added lines in 3 files covered. (97.14%)

45161 of 60627 relevant lines covered (74.49%)

162184.3 hits per line