babelfish-for-postgresql / babelfish_extensions / 8643122154

76%

BABEL_5_X_DEV: 77%

push

github

Fix handling for TVP to allow mixed declaration of named and unnamed parameters (#2478)

Babelfish is throwing an error "not all Parameters have names" when SP_EXECSQL contains TVP. This is occurring due
to incorrect assumption about whether all parameters have names or not. But in theory there could be names for few
parameters and no names for other.

This commit modified logic in tdsrpc.c file to correctly set the flag so that we could assign a name for unnamed
parameters and use the existing name for named parameters which allows us for mixed declaration use for both named
and unnamed parameters. Also, added test cases for this issue

Task: BABEL- 4707
Signed-off-by: Anikait Agrawal <agraani@amazon.com>

4 of 5 new or added lines in 2 files covered. (80.0%)

41149 of 56704 relevant lines covered (72.57%)

64818.2 hits per line