babelfish-for-postgresql / babelfish_extensions / 10099031439

75%

BABEL_5_X_DEV: 76%

Build Type

push

github

Committed by web-flow

Commit Message

Improve logic to extract identifier names (#2748)

Previously, the logic to extract original identifier names from query string was not proper and could not handle the identifiers with special characters or object name being prefix of schema name. This logic was there to extract original table name and original function/procedure name from the query and due to this issue, we were storing wrong original names.
Implemented helper function extract_multipart_identifier_name which improves the logic to extract original name from a multi-part identifier in a query string taking care of spaces or possibly quoted identifier. It internally uses extract_identifier function to extract individual parts of an identifier.

Additional fixes:
Fixed sp_rename_internal to properly handle rename of a table so that it also updates the underlying original table name (bbf_original_rel_name). Previously, sp_rename was using string_split() for the splitting which could not handle the quotes or special characters. Implemented helper SQL function babelfish_split_identifier which is mostly a wrapper over split_object_name C function to correctly split multi-part identifiers.
Updated logic to fetch original table_name/column_name in sql views information_schema_tsql.columns_internal and information_schema_tsql.tables so that they don't assume that bbf_original_rel_name or bbf_original_name is always the first option in reloptions and attoptions list respectively, instead now the logic is to iterate over the whole list and search of the desired option.

Task: BABEL-5089
Signed-off-by: Rishabh Tanwar ritanwar@amazon.com

Run Details

83 of 86 new or added lines in 5 files covered. (96.51%)

1 existing line in 1 file now uncovered.

43537 of 59210 relevant lines covered (73.53%)

107241.56 hits per line