11164747429
76%
BABEL_5_X_DEV: 77%

Ran 03 Oct 2024 03:53PM UTC

Jobs 1

Files 115

Run time 1min

Badge

Embed ▾

Committed 03 Oct 2024 03:16PM UTC coverage: 74.474%. Remained the same

Build # 11164747429

Build Type

push

github

Committed by

web-flow

Commit Message

Dump physical database aclprivs for fixed database roles (#3003)

We were not dumping the acls on physical database granted to fixed database roles of user defined databases in babelfish dump and restore. As a result after bbf dump CREATE SCHEMA. would fail we permission denied error.

As a fix, dump a DO block which will run all the grant statements again for the fixed database roles for user defined logical databases. While running these grants we will switch to sysadmin because it has all the necessary permissions to grant and so that DROP DATABASE also works correctly. We internally switch to sysadmin when executing revoke commands during drop db commands, which would only work if grantor was also sysadmin.

Test Scenario: CREATE SCEHMA works for dbo user after babelfish dump restore.
Added future proofing, when new fixed db roles are supported there will be test failures if physical database aclprivs are not dumped.

Engine PR : https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/456
Extension PR : https://github.com/babelfish-for-postgresql/babelfish_extensions/pull/3003 

Task: BABEL-5294
Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

Run Details

45121 of 60586 relevant lines covered (74.47%)

162083.77 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	11164747429.1	03 Oct 2024 03:53PM UTC	115	74.47	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 11164747429
76%
BABEL_5_X_DEV: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11164747429

babelfish-for-postgresql / babelfish_extensions / 11164747429 76% BABEL_5_X_DEV: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 11164747429

babelfish-for-postgresql / babelfish_extensions / 11164747429
76%
BABEL_5_X_DEV: 77%

README BADGES
x