babelfish-for-postgresql / babelfish_extensions / 11914680412

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix resetting some GUCs at the time of TDSResetConnection (#3096)

Some GUCs had an issue with being reset at time of TDSResetConnection:

1. Explain GUCs, they were not getting setting reset after TDSResetConnection. To fix this we need to reset it at time TDSResetConnection AND also at time of sys.sp_reset_connection execution(which would otherwise have given explain output).
2. ANSI_DEFAULTS and IMPLICIT_TRANSACTION related GUCs. These were getting set when driver sends some TDS flags. But after ResetConnection they were being rolled-back. To avoid this we implement TdsResetLoginFlags a wrapper to Re-ProcessLoginFlags.
3. We restrict the setting and re-setting of important GUCs like "babelfishpg_tsql.migration_mode" and "role", since once set, cannot be reset.

Issues Resolved:
BABEL-5280, BABEL-5276, BABEL-5278

Run Details

12 of 12 new or added lines in 5 files covered. (100.0%)

8 existing lines in 3 files now uncovered.

45731 of 61211 relevant lines covered (74.71%)

162008.08 hits per line