babelfish-for-postgresql / babelfish_extensions / 9111092279

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Update PG_FINALLY to PG_CATCH for sp_describe_undeclared_parameters_internal (#2578)

This commit updates the PG_FINALLY to PG_CATCH for sp_describe_undeclared_parameters_internal as we should not PG_RE_THROW() from a PG_FINALLY block but we to return as the function is a non void returning function. Maybe it is safe to SRF_RETURN_DONE(funcctx); but in any unexpected case we may get. segfault as funcctx is initialised inside PG_TRY block. So better to use PG_CATCH

Issues Resolved: BABEL-4869

Signed-off-by: Shameem Ahmed shmeeh@amazon.com

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

3 existing lines in 1 file now uncovered.

41811 of 57457 relevant lines covered (72.77%)

102339.53 hits per line