babelfish-for-postgresql / babelfish_extensions / 11913202982

76%

BABEL_5_X_DEV: 77%

push

github

Do not allow sp_ procedure calls in a SQL function (#3126)

T-SQL does not allow calling a stored procedure in a user-defined SQL function and will raise an execution-time error when such an execution is attempted. Babelfish currently enforces this for regular stored procedures, but not for system stored procedures (those whose names start with sp_). Some Babelfish releases ago, executing a system stored procedure in a function would crash the PG server, though in the latest codeline this may just raise an error like InstrStartNode called twice in a row.
The reason is simply that the check in exec_stmt_exec() does not cover the case of a call to a system stored procedure, therefore this fix adds this check to exec_stmt_exec_sp() as well.

NB. This is an execution-time check, presumably because SQL Server allows so-called extended stored procedures (named xp_something) to be called from functions, and these can also be called through a variable -- though neither variable procedure names nor extended stored procedures are currently supported in Babelfish.

Task: BABEL-1730

Signed-off-by: Rob Verschoor rcv@amazon.com

2 of 2 new or added lines in 1 file covered. (100.0%)

45726 of 61200 relevant lines covered (74.72%)

162380.69 hits per line