babelfish-for-postgresql / babelfish_extensions / 9216318282

76%

BABEL_5_X_DEV: 77%

push

github

Update TDS error handling to support special characters (#2603)


This commit modifies TDS error message handling to add support for special characters such as emojis
An earlier commit introduced error handling when users attempt to create a procedure / function with the same name as one that is already defined. In recent testing, we found that if a user attempts to recreate an existing procedure that contains certain special characters, there will be a TDS error.
We are relying on pg_mbstrlen to calculate the error string length (code link). This pg_mbstrlen would calculate length of certain characters such as emoji and others as a 1 whereas it should be counted as 2 in UTF16. Hence, for given error string, pg_mbstrlen is calculating the length of error string as 91 whereas it should be 93 characters in UTF16. So we need to update this logic to compute messageLen_16 to use messageUtf16.len / 2 instead of using pg_mbstrlen.

Issue Resolved: BABEL-4972
Signed-off-by: Jake Owen <owjco@amazon.com>

1 of 1 new or added line in 1 file covered. (100.0%)

41902 of 57490 relevant lines covered (72.89%)

108166.73 hits per line