babelfish-for-postgresql / babelfish_extensions / 10184739814

76%

BABEL_5_X_DEV: 77%

push

github

Fix behaviour of error message for GRANT (#2810)


Currently on executing queries like "GRANT EXECUTE ON PROCEDURE::test TO public;", babelfish throws error with error message 'GRANT ON PROCEDURE is not currently supported in Babelfish' which is incorrect as the above query has an incorrect syntax. With this change it now shows 'syntax error' for such cases and 'not currently supported' for allowed object types (according to GRANT documentation) which are not supported by us currently.

The issue arrised because the GRANT query is being successfully parsed
by our antlr parser and then the check for supported/unsupported occurs
resulting in the error being thrown in the
TsqlUnsupportedFeatureHandler() rather than the antlr parser.

In the rule definition of GRANT/REVOKE/DENY in TSqlParser.g4, object_type is used which contains some types like PROCEDURE, TABLE which are not syntactically correct according to the GRANT/REVOKE/DENY documentation. In this PR, I have created a new permission_object_type which contains only those types which are syntactically correct for GRANT/REVOKE/DENY and added relavent tests for the same. After this change, babelfish throws error during the parsing and gives syntax error.

Signed-off-by: P Aswini Kumar <aswinii@amazon.com>
Task: BABEL-5079

6 of 6 new or added lines in 2 files covered. (100.0%)

43913 of 59682 relevant lines covered (73.58%)

125422.36 hits per line