babelfish-for-postgresql / babelfish_extensions / 13538561076

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Override max length of 0 for char parameter types in an RPC (#3515) (#3533)

In a TDS remote procedure call (RPC), the max length of char based
datatypes can be 0 - 8000. The typmod of the base PG type that we map the
RPC parameter to is directly related to the max length of the parameter
type specified in the RPC. For char/varchar typmod = maxLen and for
nchar/nvarchar typmod = maxLen / 2. Thus, if maxLen = 0, we will
translate it to typmod of 0 which is invalid for char based types in PG.

To fix this, if the max length of the RPC parameter on the wire is 0, we
will override the max length to the maximum permissible length of PG
char types i.e. 8000.

Task: BABEL-5639

Signed-off-by: Sharu Goel <goelshar@amazon.com>

Run Details

1 of 2 new or added lines in 1 file covered. (50.0%)

1 existing line in 1 file now uncovered.

47106 of 62812 relevant lines covered (75.0%)

186130.66 hits per line