7638378864
75%

Ran 24 Jan 2024 10:27AM UTC

Jobs 1

Files 113

Run time 9s

Badge

Embed ▾

Committed 24 Jan 2024 09:50AM UTC coverage: 71.843% (+0.001%) from 71.842%

Build # 7638378864

Build Type

push

github

Committed by

web-flow

Commit Message

Fix Invalid Protocol Error when using CachedRowSet with JDBC Driver (#2278)

When a user uses CachedRowSet API present in jdbc driver , an invalid TDS stream error is thrown by the driver for Babelfish, this is caused due to the improper calculation of nullMapSize that is sent after the NBCROW row token for sp_cursorfetch RPC call.
According to old logic ,Consider a case where the result set has 32 columns (or any perfect multiple of 8)
nullMapSize = (natts + 7) / 8;
This gives us the size as 4 but we also send a ROWSTAT column along with sp_cursor* RPC calls (Check SendCursorResponse)
So the driver gets the length of columns as 33 instead of 32 from ColMetadata token and uses this information to calculate the size of null map (link) which turns out to be 5 ,this doesnt cause any immediate issue but will cause the further bytes in the packet to be offset by 1 leading to incorrect values.

The new logic fixes this by adding rowstat column into size calculation and also uses bitshift instead of division to improve performance.
Issues Resolved

BABEL-4511

Signed-off-by: Nirmit Shah nirmisha@amazon.com

Signed-off-by: Nirmit Shah nirmisha@amazon.com

Run Details

39811 of 55414 relevant lines covered (71.84%)

58854.95 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7638378864.1	24 Jan 2024 10:27AM UTC	113	71.84	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 7638378864
75%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7638378864

babelfish-for-postgresql / babelfish_extensions / 7638378864 75%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7638378864

babelfish-for-postgresql / babelfish_extensions / 7638378864
75%

README BADGES
x