7538246179
76%
BABEL_5_X_DEV: 77%

Ran 16 Jan 2024 07:55AM UTC

Jobs 1

Files 113

Run time 10s

Badge

Embed ▾

Committed 16 Jan 2024 07:17AM UTC coverage: 71.703% (-0.001%) from 71.704%

Build # 7538246179

Build Type

push

github

Committed by

web-flow

Commit Message

Fix SPI clean up incase of errors for insert into execute with @tablevarible (#2183) (#2237)

Fix crash in insert into @tablevariable execute('some error generating statement')
Problem was how we were handling SPI connections clean up.
We marked the SPI connections as internal xact only when we were not inside a sys function or non tsql procedure.
But we always call SPI finish in following terminate batch. Marking it non internal will clean up the SPI connections when we abort transaction in error handling.

As a fix we always mark the SPI connection as internal_xact for pltsql_inline_handler and pltsql_call_handler. Also clean up any leftovers SPI connections in terminate_batch. If we are less than expected spi stack depth we throw a fatal error to kill session since this state is never expected.

Also make some changes to fix static code analyzer warnings for uninitialised variables in pltsql call handler.

Engine PR: https://github.com/babelfish-for-postgresql/postgresql_modified_for_babelfish/pull/274

Issues Resolved: BABEL-4360

Signed-off-by: Tanzeel Khan <tzlkhan@amazon.com>

Run Details

39364 of 54899 relevant lines covered (71.7%)

57562.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7538246179.1	16 Jan 2024 07:54AM UTC	113	71.7	GitHub Action Run

babelfish-for-postgresql / babelfish_extensions / 7538246179
76%
BABEL_5_X_DEV: 77%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7538246179

babelfish-for-postgresql / babelfish_extensions / 7538246179 76% BABEL_5_X_DEV: 77%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7538246179

babelfish-for-postgresql / babelfish_extensions / 7538246179
76%
BABEL_5_X_DEV: 77%

README BADGES
x