babelfish-for-postgresql / babelfish_extensions / 14030250995

76%

BABEL_5_X_DEV: 77%

Build Type

push

github

Committed by web-flow

Commit Message

Fix issue with truncation of result of arithmetic computations to correct scale when result is of numeric datatype (#3455) (#3611)

Currently, whenever an arithmetic operation is performed which results in numeric/decimal, we are storing the result till maximum possible scale instead of the correct scale. This is causing incorrect results in some arithmetic operations such as numeric division, numeric multiplication etc. This PR will fix this issue by adding a hooks in engine which truncates/rounds the result value to the correct scale and also sets the correct typmod of multiple nodes whose base type is NUMERIC.

This PR also fixes precision overflow adjustment logic in case NUMERIC ADDITION, SUBTRACTION and MULTIPLICATION.

Engine PR: babelfish-for-postgresql/postgresql_modified_for_babelfish#529

Tasks: BABEL-5467, BABEL-5685

Signed-off-by: Rohit Bhagat <rohitbgt@amazon.com>
Co-authored-by: Rohit bhagat <65351720+rohit01010@users.noreply.github.com>

Run Details

143 of 158 new or added lines in 3 files covered. (90.51%)

1 existing line in 1 file now uncovered.

47740 of 63584 relevant lines covered (75.08%)

237023.84 hits per line