7497761510
75%
BABEL_5_X_DEV: 76%

Ran 12 Jan 2024 04:42AM CUT

Jobs 1

Files 113

Run time 12s

Badge

Embed ▾

Committed 12 Jan 2024 04:04AM CUT coverage: 71.703% (+0.003%) from 71.7%

Build # 7497761510

Build Type

push

github

Committed by

web-flow

Commit Message

Fix valgrind warnings related to varcharvarbinary function (#2245)

Currently, we have defined the following cast functions which call varcharvarbinary C function with only 1 argument. But, in varcharvarbinary function, we are reading two arguments which might lead to memory related issues.

sys.binarysysvarchar
sys.binaryvarchar
sys.rowversionsysvarchar
sys.rowversionvarchar

This change modifies the above casts to have 3 arguments, one for input, one for typmod (integer) and the other for specifying isExplicit (boolean)

This change also replaces varcharTypeName->typeOid with baseTypeId in tsql_coerce_string_literal_hook() function as we are not setting varcharTypeName->typeOid at all which causes failure while trying to fetch the PG view definition as shown below.

Ex :
-- T-SQL endpoint
1> create view babel_4475_v1 as select cast(cast('a' as binary(2)) as varchar(2))
2> go

-- PSQL endpoint
jdbc_testdb=# select pg_catalog.pg_get_viewdef(oid, true) from pg_class where relname = 'babel_4475_v1';
ERROR:  cache lookup failed for type 0
jdbc_testdb=#

Issues Resolved: BABEL-4475
Signed-off-by: Sai Rohan Basa <bsrohan@amazon.com>

Run Details

39365 of 54900 relevant lines covered (71.7%)

57462.27 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	7497761510.1	12 Jan 2024 04:42AM CUT	113	71.7	GitHub Action Run

Source Files on build 7497761510

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	contrib/babelfishpg_tsql/src/tsqlNodes.c	40	18	0	18	0.0
0.0	.../mb/conversion_procs/utf8_and_big5/utf8_and_big5.c	32	4	0	4	0.0
0.0	contrib/babelfishpg_tsql/src/tsqlHandler.c	29	5	0	5	0.0
0.0	contrib/babelfishpg_tsql/src/fts_parser.y	227	59	0	59	0.0
0.0	...rc/backend/fault_injection/fault_injection_tests.c	253	106	0	106	0.0
0.0	...ontrib/babelfishpg_tsql/src/tsql_for/forjson_old.c	358	136	0	136	0.0
0.0	contrib/babelfishpg_tsql/src/tsql_for/forxml_old.c	283	95	0	95	0.0
0.0	contrib/babelfishpg_tsql/src/fts_scan.l	117	28	0	28	0.0
1.18	contrib/babelfishpg_tsql/src/pl_gram.y	8370	3221	38	3183	3333.0
1.79	..._tds/src/backend/fault_injection/fault_injection.c	406	168	3	165	8.0

71.7
contrib/

babelfish-for-postgresql / babelfish_extensions / 7497761510
75%
BABEL_5_X_DEV: 76%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7497761510

babelfish-for-postgresql / babelfish_extensions / 7497761510 75% BABEL_5_X_DEV: 76%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 7497761510

babelfish-for-postgresql / babelfish_extensions / 7497761510
75%
BABEL_5_X_DEV: 76%

README BADGES
x