babelfish-for-postgresql / babelfish_extensions / 9416708039

75%

Build Type

push

github

Committed by web-flow

Commit Message

Fix issues while CASTing string literal to datetime, datetime2 and datetimeoffset (#2621)

This PR addresses the behavioural differences in CASTing of string literals to datetime, datetime2 and datetimeoffset. The following changes have been made to fix the issue :

Currently, we use native PG function named ParseDateTime for parsing the input string literals. This function does not handle some cases such as empty spaces between the fields. We have created a function named cleanup_input_str which will modify the input string to remove all the unnecessary spaces and then call the inbuilt ParseDateTime function.
ParseDatetime splits the input string to different fields which then will be decoded in native function namedDecodeDateTime. But DecodeDatetime will not handle some cases such as accepting : as a separator for seconds and milliseconds. These additional cases were handled in a different function named tsql_decode_datetime_fields .
Also, if there is a text month we check the REGEX of the input str so that it matches the T-SQL behaviour

Issues Resolved: BABEL-4328

Signed-off-by: Sai Rohan Basa bsrohan@amazon.com

Run Details

376 of 383 new or added lines in 3 files covered. (98.17%)

3 existing lines in 1 file now uncovered.

42284 of 57874 relevant lines covered (73.06%)

109596.7 hits per line