babelfish-for-postgresql / babelfish_extensions / 10993868188

76%

BABEL_5_X_DEV: 77%

push

github

Fix valgrind warning in bbf_create_partition_tables function (#2954)

* Fix valgrind warning in bbf_create_partition_tables function

During the creation of a partitioned table using a partition scheme, the range values array was extracted from the catalog, and the array values were deconstructed into datums using the deconstruct_array function. However, the catalog was closed before processing the datums returned by deconstruct_array. If the datatype of the array elements is pass-by-ref, the returned datums are pointers to the array object, which can lead to an invalid read after closing the catalog.

This commit fixes the issue by keeping the catalog open until all the processing of the datums returned by deconstruct_array is complete in bbf_create_partition_tables and search_partition functions.

Signed-off-by: Sumit Jaiswal sumiji@amazon.com

Issues Resolved
Task: BABEL-5213

6 of 6 new or added lines in 2 files covered. (100.0%)

44974 of 60398 relevant lines covered (74.46%)

162756.71 hits per line