babelfish-for-postgresql / babelfish_extensions / 11290454460
76%
BABEL_5_X_DEV: 77%

LAST BUILD BRANCH: datetime2fromparts_bugfix
DEFAULT BRANCH: BABEL_5_X_DEV
Ran
Jobs 1
Files 115
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 74.487% (-0.003%) from 74.49%
11290454460

push

github

web-flow 
Add '\' as ESCAPE character for sp_columns_100 for table_owner parameter (#3014)

There are few occurrences where we use procedure sp_columns_100 to fetch column metadata. The issue with this procedure is, when the table_owner (schema name) contains _ character, we may obtain some unexpected output . This is because in some places we are using using sp_columns_100 incorrectly with a backslash escaping underscores (e.g. “_“). Underscores are wildcards in sp_columns_100 (and in LIKE in general), but sp_columns_100 does not use a backslash as an escape character.
Till now, sp_columns_100 , was invoking a plpgsql function sp_column_100_internal which used PG’s LIKE operator for table_owner, which does use a backslash as the default escape character.

With BABEL-4953, we have updated the definition of sp_columns_100 where we removed redundant function call and implemented the procedure by using TSQL LIKE operator on column name, which will create some problems in other places.

The change in the new version is correct. However, since currently we rely on the incorrect functionality of the escape characters, we are making this temporary change for now. Once, we have fixed the dependencies on this procedure, we need to revert it.

Authored-by: Shameem Ahmed shmeeh@amazon.com
Signed-off-by: Shameem Ahmed shmeeh@amazon.com

45159 of 60627 relevant lines covered (74.49%)

162446.74 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
73.8
 -0.42% contrib/babelfishpg_tds/src/backend/tds/tdsutils.c
Jobs
ID Job ID Ran Files Coverage
1 11290454460.1 115
74.49
 GitHub Action Run
Source Files on build 11290454460