bitcoindevkit / bdk / 8906477466

86%

push

github

Merge bitcoindevkit/bdk#1413: Introduce universal sync/full-scan structures for spk-based syncing

<a class=hub.com/bitcoindevkit/bdk/commit/c0374a0eeb155f1cb4f9d99223f6bc65d24f7df8">c0374a0ee<a href="https://github.com/bitcoindevkit/bdk/commit/08fac47c2921ffd8d8e1b8d223bc89ae7e94abb1"> feat(chain): `SyncRequest` now uses `ExactSizeIterator`s (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/0f94f24aaf6374fe2d7c2abf32a870d3849fb8cc">0f94f24aa</a><a href="https://github.com/bitcoindevkit/bdk/commit/08fac47c2921ffd8d8e1b8d223bc89ae7e94abb1"> feat(esplora)!: update to use new sync/full-scan structures (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/4c52f3e08e85e73db379ee3411cceb8dbcec92e1">4c52f3e08</a><a href="https://github.com/bitcoindevkit/bdk/commit/08fac47c2921ffd8d8e1b8d223bc89ae7e94abb1"> feat(wallet): make wallet compatible with sync/full-scan structures (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/cdfec5f90726f2313963c3a71e5d18bb10624736">cdfec5f90</a> feat(chain): add sync/full-scan structures for spk-based syncing (志宇)

Pull request description:

  Fixes #1153
  Replaces #1194

  ### Description

  Introduce universal structures that represent sync/full-scan requests/results.

  ### Notes to the reviewers

  This is based on #1194 but is different in the following ways:
  * The functionality to print scan/sync progress is not reduced.
  * `SyncRequest` and `FullScanRequest` is simplified and fields are exposed for more flexibility.

  ### Changelog notice

  * Add universal structures for initiating/receiving sync/full-scan requests/results for spk-based syncing.
  * Updated `bdk_esplora` chain-source to make use of new universal sync/full-scan structures.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

ACKs for top commit:
  notmandatory:
    tACK c0374a0eeb155f1cb4f9d99223f6bc65d24f7df8

Tree-SHA512: c2ad66d9702670651a5e3f1955f6c6d42be

92 of 282 new or added lines in 4 files covered. (32.62%)

10310 of 12214 relevant lines covered (84.41%)

17748.86 hits per line