Ran
|
Jobs
1
|
Files
40
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1408: Fix: enable blocking-https-rustls feature on esplora client <a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/d3a14d411d2a1a37f07e42c28eae3a1836aec14d">d3a14d411 fix: enable blocking-https-rustls feature on esplora client (thunderbiscuit) Pull request description: The [`blocking` feature on the rust-esplora-client library](https://github.com/bitcoindevkit/rust-esplora-client/blame/master/Cargo.toml#L35) changed from ureq to minreq, which does not come with https enabled by default, breaking previously working code that simply enabled the `blocking` feature on the `bdk_esplora` crate. This change will enable what is currently the "default https" [flag for the minreq library](https://docs.rs/minreq/latest/minreq/#https-or-https-rustls) when using the `blocking` feature on bdk_esplora, reverting that breaking change. ### Notes to the reviewers Another way we could do this (let me know if this is preferable) is to add a new feature called `blocking-https-rustls`: ```rust blocking = ["esplora-client/blocking"] blocking-https-rustls = ["esplora-client/blocking-https-rustls"] ``` ### Changelog notice <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md) * [x] I ran `cargo fmt` and `cargo clippy` before committing #### New Features: * [x] I've added tests for the new feature * [x] I've added docs for the new feature #### Bugfixes: * [ ] This pull request breaks the existing API * [ ] I've added tests to reproduce the issue which are now passing * [ ] I'm linking the issue being fixed by this PR ACKs for top commit: storopoli: ACK d3a14d411d2a1a37f07e42c28eae3a1836aec14d evanlinjin: ACK d3a14d411d2a1a37f07e42c28eae3a1836aec14d Tree-SHA512: d25... (continued)
9628 of 11365 relevant lines covered (84.72%)
17470.19 hits per line
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 8763624781.1 | 40 |
84.72 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|