Ran
|
Jobs
1
|
Files
47
|
Run time
1min
|
Badge
Embed ▾
README BADGES
|
push
github
Merge bitcoindevkit/bdk#1561: refactor(bdk_hwi): remove `bdk_hwi`, as `HWISigner`'s being moved to `rust-hwi` cd8ddfe18 chore: remove `ci/automation.json` file, used by Dockerfile.ledger (Leonardo Lima) 75c97a601 fix(ci)!: remove `Dockerfile.ledger` and `hwi` steps from coverage step (Leonardo Lima) b118b82fb refactor(bdk_hwi)!: remove `bdk_hwi` (Leonardo Lima) 43257cfca refactor(wallet)!: remove dangling unused `hardwaresigner.rs` file (Leonardo Lima) Pull request description: <!-- You can erase any parts of this template not applicable to your Pull Request. --> fixes #1516 depends on https://github.com/bitcoindevkit/rust-hwi/pull/104 ### Description <!-- Describe the purpose of this PR, what's being adding and/or fixed --> This PR removed the `bdk_hwi` crate, and the dangling `hardwaresigner.rs` file from `bdk_wallet` crate. It simplifies the BDK project workspace as it removes the dependency on `rust-hwi`, pyo3 and some required steps on CI. The removal is fine, as the `HWISigner` is being moved to `rust-hwi` project instead, please check: https://github.com/bitcoindevkit/rust-hwi/pull/104 ### Notes to the reviewers <!-- In this section you can include notes directed to the reviewers, like explaining why some parts of the PR were done in a specific way --> Please let me know what you think about the removal, and if I missed anything. ### Changelog notice <!-- Notice the release manager should include in the release tag message changelog --> <!-- See https://keepachangelog.com/en/1.0.0/ for examples --> - Removed dangling unused `hardwaresigner.rs` file from `bdk_wallet` crate. - Removed `bdk_hwi` crate, moved to `rust-hwi` project. ### Checklists #### All Submissions: * [x] I've signed all my commits * [x] I followed the [contribution guidelines](https://github.com/bit... (continued)
11103 of 13559 relevant lines covered (81.89%)
14116.2 hits per line
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
1 | 10818492517.1 | 47 |
81.89 |
GitHub Action Run |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|