bitcoindevkit / bdk / 6192744084

83%

push

github

Merge bitcoindevkit/bdk#1084: Enhance bdk chain structures

<a class=hub.com/bitcoindevkit/bdk/commit/1ff806c67f4da9ba58b7c7689fde0fe41a34a6f5">1ff806c67<a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> fix(chain)!: rm weird `From` impl (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/d43ae0231fa4670b98780cad84466c14ae087292">d43ae0231</a><a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> refactor: improve docs, cleanup unnecessary types and improve code (Vladimir Fomene)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/41042069809e3eeb4a8cc8a5a8db1af2c57c4a11">410420698</a><a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> feat: impl Append for lots of tuples (LLFourn)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/c56728ff1315e0deaf256af07fd1ff5e18fced8a">c56728ff1</a><a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> refactor: Remove `scan` and `scan_txout` from SpkTxoutIndex and KeychainTxoutIndex (Vladimir Fomene)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/32c40ac939bc514ac7f1d3f1d7cd1080011e20ba">32c40ac93</a><a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> feat(electrum)!: change signature of `ElectrumExt` (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/a28748c33976312b9e6671636ab7e305323efb03">a28748c33</a><a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> refactor: Implement Default for WalletUpdate (Vladimir Fomene)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/f42f8b8ff19c2e67888b476487e4e5c9edb0d0ff">f42f8b8ff</a><a href="https://github.com/bitcoindevkit/bdk/commit/c20a4da9fc902a062eb217b39e37a32d9e64a148"> refactor: Allow for no chain update (Vladimir Fomene)
68572bfd2 refactor: move WalletChangeset to wallet module (Vladimir Fomene)
2392e50fd refactor: Move WalletUpdate to wallet module (Vladimir Fomene)
7c12dc994 refactor: Remove ForEachTxout trait (Vladimir Fomene)
6bcbb9323 refactor: Edit ElectrumExt not to use WalletUpdate (Vladimir Fomene)

Pull request description:

  ### Description

  Fixes #1061

  ### Changelog notice

  - Move WalletUpdate to the wallet module
  - Remove ForEachTxout trait completely
  - Refactor ElectrumExt to not use WalletUpdate.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 1ff806c67f4da9ba58b7c7689fde0fe41a34a6f5

Tree-SHA512: 05349713a6adf2f93007816c4d305ed65a2

115 of 115 new or added lines in 5 files covered. (100.0%)

8033 of 10179 relevant lines covered (78.92%)

5214.03 hits per line