bitcoindevkit / bdk / 9502207523

79%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1463: No descriptor ids in spk txout index

8dd174479 refactor(chain): compute txid once for `KeychainTxOutIndex::index_tx` (志宇)
639d735ca refactor(chain): change field names to be more sane (志宇)
5a02f4012 docs(chain): fix docs (志宇)
c77e12bae refactor(chain): `KeychainTxOutIndex` use `HashMap` for fields (志宇)
4d3846abf chore(chain): s/replenish_lookahead/replenish_inner_index/ (LLFourn)
8779afdb0 chore(chain): document insert_descriptor invariants better (LLFourn)
69f2a695f refactor(chain): improve replenish lookeahd internals (LLFourn)
5a584d0fd chore(chain): Fix Indexed and KeychainIndexed documentaion (Lloyd Fournier)
b8ba5a020 chore(chain): Improve documentation of keychain::ChangeSet (LLFourn)
101a09a97 chore(chain): Standardise KeychainTxOutIndex return types (LLFourn)
bce070b1d chore(chain): add type IndexSpk, fix clippy type complexity warning (Steve Myers)
4d2442c37 chore(chain): misc docs and insert_descriptor fixes (LLFourn)
bc2a8be97 refactor(keychain): Fix KeychainTxOutIndex range queries (LLFourn)
3b2ff0cc9 Write failing test for keychain range querying (LLFourn)

Pull request description:

  Fixes #1459

  This reverts part of the changes in #1203. There the `SpkTxOutIndex<(K,u32)>` was changed to `SpkTxOutIndex<(DescriptorId, u32>)`. This led to a complicated translation logic in  `KeychainTxOutIndex` (where the API is based on `K`) to transform calls to it to calls to the underlying `SpkTxOutIndex` (which now indexes by `DescriptorId`). The translation layer was broken when it came to ... (continued)

Run Details

257 of 311 new or added lines in 6 files covered. (82.64%)

4 existing lines in 1 file now uncovered.

11203 of 13479 relevant lines covered (83.11%)

16965.23 hits per line