bitcoindevkit / bdk / 9841407619

83%

push

github

Merge bitcoindevkit/bdk#1503: feat(wallet): simplify  `public_descriptor` fn and remove `get_descriptor_for_keych…

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/e7ec5a873328c9b68836306086bd9b021e9c952a">e7ec5a873 refactor(wallet)!: remove redundant get_descriptor_for_keychain (Giovanni Napoli)

Pull request description:

  Fixes #1501

  ### Description

  Simplifies `public_descriptor` function by using `get_descriptor` and removes `get_descriptor_for_keychain`.

  ### Notes to the reviewers

  Tested with `cargo test --all-features`.

  ### Changelog notice

  - Simplifies `public_descriptor` function and removes `get_descriptor_for_keychain`

  ### Checklists

  #### All Submissions:

  * [X] I've signed all my commits
  * [X] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [X] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    ACK e7ec5a873328c9b68836306086bd9b021e9c952a
  storopoli:
    ACK https://github.com/bitcoindevkit/bdk/commit/e7ec5a873328c9b68836306086bd9b021e9c952a

Tree-SHA512: 5981190ac99a8ae2a46a6918d9eea16b44a

10 of 10 new or added lines in 3 files covered. (100.0%)

11120 of 13357 relevant lines covered (83.25%)

16709.95 hits per line