bitcoindevkit / bdk / 9630127950

83%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk#1395: Remove `rand` dependency from `bdk`

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/4bddb0de6262fb4014d51baf8c9453eb45a3d0ef">4bddb0de6<a href="https://github.com/bitcoindevkit/bdk/commit/6dab68d35b60713448c17a9784adaf660057c53f"> feat(wallet): add back TxBuilder finish() and sort_tx() with thread_rng() (Steve Myers)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/45c0cae0a461232bf746375083e2005c5df5f913">45c0cae0a</a> fix(bdk): remove rand dependency (rustaceanrob)

Pull request description:

  ### Description

  WIP towards removing `rand` fixes #871

  The `rand` dependency was imported explicitly, but `rand` is also implicitly used through the `rand-std` feature flag on `bitcoin`.

  ### Notes to he reviewers

  **Updated:**

  `rand` was used primarily in two parts of `bdk`. Particularly in signing and in building a transaction.

  Signing:
  - Used implicitly in [`sign_schnorr`](https://docs.rs/bitcoin/latest/bitcoin/key/struct.Secp256k1.html#method.sign_schnorr), but nowhere else within `signer`.

  Transaction ordering:
  - Used to shuffle the inputs and outputs of a transaction, the default
  - Used in the single random draw __as a fallback__ to branch and bound during coin selection. Branch and bound is the default coin selection option.

  See conversation for proposed solutions.

  ### Changelog notice

  - Remove the `rand` dependency from `bdk`

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

  #### Bugfixes:

  * [x] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  ValuedMammal:
    ACK 4bddb0de6262fb4014d51baf8c9453eb45a3d0ef
  notmandatory:
    ACK 4bddb0de6262fb4014d51baf8c9453eb45a3d0ef

Tree-SHA512: 662d9bcb137ba713ebb0bfd19c66163a... (continued)

Run Details

154 of 160 new or added lines in 6 files covered. (96.25%)

44 existing lines in 3 files now uncovered.

11136 of 13413 relevant lines covered (83.02%)

16602.86 hits per line