bitcoindevkit / bdk / 8401230635

83%

push

github

Merge bitcoindevkit/bdk#1171: chore: extract `TestEnv` into separate crate

<a class=hub.com/bitcoindevkit/bdk/commit/7c9ba3cfc855dc0845476fe923dac4e47cb5c06a">7c9ba3cfc<a href="https://github.com/bitcoindevkit/bdk/commit/80e190b3e734a46ba73925d381fe4f1a9941bf2a"> chore(electrum,testenv): move `test_reorg_is_detected_in_electrsd` (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/2462e9041599f395673f9b14f0b618877832f099">2462e9041</a><a href="https://github.com/bitcoindevkit/bdk/commit/80e190b3e734a46ba73925d381fe4f1a9941bf2a"> chore(esplora): rm custom WASM target spec test dependency (志宇)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/04d0ab5a978fbfd45a5c795f9142ff4a9ba29ee3">04d0ab5a9</a><a href="https://github.com/bitcoindevkit/bdk/commit/80e190b3e734a46ba73925d381fe4f1a9941bf2a"> test(electrum): added scan and reorg tests Added scan and reorg tests to check electrum functionality using `TestEnv`. (Wei Chen)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/4edf533b678cb21f4c29ded22692e607ff75e2cd">4edf533b6</a><a href="https://github.com/bitcoindevkit/bdk/commit/80e190b3e734a46ba73925d381fe4f1a9941bf2a"> chore: extract `TestEnv` into separate crate `TestEnv` is extracted into its own crate to serve as a framework for testing other block explorer APIs. (Wei Chen)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/6e648fd5afa188290b05f8e050ba69fe5f8b80e4">6e648fd5a</a> chore: update MSRV dependency for nightly docs (Wei Chen)

Pull request description:

  ### Description

  `TestEnv` is extracted into its own crate with `electrsd` support added so that `TestEnv` can also serve `esplora` and `electrum`.
  The tests in the `esplora` crate have also been updated to use `TestEnv`.

  The `tx_can_become_unconfirmed_after_reorg()` test in `test_electrum` suggests that the electrum issue where a reorged tx would be stuck at confirmed does not exist anymore.

  ### Notes to the reviewers

  The code for `tx_can_become_unconfirmed_after_reorg()` was adapted from the same test in `bitcoind_rpc/test_emitter`. This electrum version of the test requires extra review, as I am uncertain if I used the API efficiently.

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 7c9ba3cfc855dc0845476fe923dac4e47cb5c06a

Tree-SHA512: 36c6501e410ab758aa3b37123d6c56b7139

172 of 186 new or added lines in 2 files covered. (92.47%)

9592 of 11360 relevant lines covered (84.44%)

5811.22 hits per line