bitcoindevkit / bdk / 7722898151

84%

push

github

Merge bitcoindevkit/bdk#1279: Filter duplicate coins before coin selection

<a class=hub.com/bitcoindevkit/bdk/commit/5299db34cb9117ad1b66a6afcb51f6ca7e1f0d95">5299db34c<a href="https://github.com/bitcoindevkit/bdk/commit/070fffb95cddb9153f326d5662f206d25ecbcc7c"> fix(wallet): filter duplicates before coin selection (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/d9501187ef3c4436b7baedb23a4d4f6b1f46a03d">d9501187e</a> test(wallet): fix tests helpers to generate unique utxos (志宇)

Pull request description:

  Fixes #1240

  ### Description

  We now filter out duplicate coins before calling `CoinSelectionAlgorithm::coin_select`. If a UTXO exists in both `required_utxos` and `optional_utxos`, only the copy in `required_utxos` will be kept.

  Test helper methods are also updated to not create duplicate UTXOs.

  ### Changelog notice

  Fixed

  * Filter out duplicate UTXOs before calling `CoinSelectionAlgorithm::coin_select`. If a UTXO exists in both `required_utxos` and `optional_utxos`, only the copy in `required_utxos` will be kept.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  ~* [ ] This pull request breaks the existing API~
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  danielabrozzoni:
    utACK 5299db34cb9117ad1b66a6afcb51f6ca7e1f0d95

Tree-SHA512: 9cb5517b75b1ebdd6eb562fbb923795aa04

9188 of 11440 relevant lines covered (80.31%)

5635.66 hits per line