bitcoindevkit / bdk / 9377160122

79%

push

github

Merge bitcoindevkit/bdk#1453: refactor(electrum) put the tx cache in electrum

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/2d2656acfa83ab4c4846c0aab14072efb64c5cc3">2d2656acf<a href="https://github.com/bitcoindevkit/bdk/commit/8eef350bd08057acc39b6fc50b1217db5e29b968"> feat(electrum): re-export `transaction_broadcast` method (志宇)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/53fa35096fbeea2b82b28987e8ef6f7d39ffc80b">53fa35096</a> refactor(electrum)!: put the tx cache in electrum (LLFourn)

Pull request description:

  Previously there was a `TxCache` that you passed in as part of the sync request. There are lots of downsides to this:

  1. If the user forgets to do this you cache nothing
  2. where are you meant to keep this cache? The example shows it being recreated every time which seems very suboptimal.
  3. More API and documentation surface area.

  Instead just do a plain old simple cache inside the electrum client. This way at least you only download transactions once. You can pre-populate the cache with a method also and I did this in the examples.

  * [x] This pull request breaks the existing API

ACKs for top commit:
  evanlinjin:
    self-ACK 2d2656acfa83ab4c4846c0aab14072efb64c5cc3
  notmandatory:
    ACK 2d2656acfa83ab4c4846c0aab14072efb64c5cc3

Tree-SHA512: 6c29fd4f9aacc91076b2f805ec60a00b856

94 of 184 new or added lines in 2 files covered. (51.09%)

11247 of 13525 relevant lines covered (83.16%)

16445.95 hits per line