bitcoindevkit / bdk / 10349673190

79%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1535: test(electrum): Test sync in reorg and no-reorg situations

<a class=hub.com/bitcoindevkit/bdk/commit/2c0bc45ecf0241abc8bf9d72c8bbeded53d32a45">2c0bc45ec<a href="https://github.com/bitcoindevkit/bdk/commit/caef3f476b533aa11cee2eac45eb0c16a1a0f1e9"> feat(testenv): Added `bdk_electrum` wait for Txid method (Wei Chen)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/49e1a5e871de31e87cc9a4d329cd2b1477f32fd0">49e1a5e87</a> test(electrum): Test sync in reorg and no-reorg situations (Wei Chen)

Pull request description:

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->
  Closes #1125.

  ### Description

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->
  Add new test for `bdk_electrum` to make sure previously unconfirmed transactions get confirmed again in both reorg and no-reorg situations.

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->
  * Added `wait_until_electrum_sees_txid` method to `TestEnv`.
  * `wait_until_electrum_sees_block` now has a `Duration` input for timeout.
  * Removed exponential polling delay in `wait_until_electrum_sees_block`.
  * Added `test_sync` to `bdk_electrum` to make sure previously unconfirmed transactions get confirmed in both reorg and no-org situations.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  evanlinjin:
    ACK 2c0bc45ecf0241abc8bf9d72c8bbeded53d32a45

Tree-SHA512: 2218151261b2624a3aba6be6a498427adf4

Run Details

19 of 25 new or added lines in 1 file covered. (76.0%)

1 existing line in 1 file now uncovered.

10915 of 13340 relevant lines covered (81.82%)

13704.42 hits per line