bitcoindevkit / bdk / 7693429307

84%

push

github

Merge bitcoindevkit/bdk#1301: Fix `ConfirmationTime` conversion from `ChainPosition`

<a class=hub.com/bitcoindevkit/bdk/commit/e687c27096e1c8f36c3a129dc6d92af9c5d05a30">e687c2709 fix(chain): convert to `ConfirmationTime` fix (志宇)

Pull request description:

  ### Description

  We forgot to include the `last_seen` when converting from `ChainPosition` to `ConfirmationTime`.

  ### Notes to the reviewers

  No brainer.

  ### Changelog notice

  * Fix `ConfirmationTime` conversion from `ChainPosition` to include the `last_seen`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  LLFourn:
    ACK e687c27096e1c8f36c3a129dc6d92af9c5d05a30

Tree-SHA512: 182f80430c156b22752552f4cd13d82ffaf

9088 of 11338 relevant lines covered (80.16%)

5569.66 hits per line