bitcoindevkit / bdk / 9394987004

83%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk#1390: Make Wallet require a change descriptor

<a class=hub.com/bitcoindevkit/bdk/commit/8bc3d35f6c83d078551c4bc57f72f13324865486">8bc3d35f6<a href="https://github.com/bitcoindevkit/bdk/commit/c5a3b62d633fc1fa0ebda144237de96dbe1636d6"> fix(wallet): `LoadError::MissingDescriptor` includes the missing KeychainKind (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/412dee1f5b027af7800ee155717d47f4ab4b60e0">412dee1f5</a><a href="https://github.com/bitcoindevkit/bdk/commit/c5a3b62d633fc1fa0ebda144237de96dbe1636d6"> ref(wallet)!: Make `Wallet::public_descriptor` infallible (valued mammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/c2513e1090374d7871a8623845bd10757e6ab0b3">c2513e109</a><a href="https://github.com/bitcoindevkit/bdk/commit/c5a3b62d633fc1fa0ebda144237de96dbe1636d6"> test(wallet): Clarify docs for get_funded_wallet (valued mammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/9d954cf7d25d43c77115cd931407005a09365389">9d954cf7d</a> refactor(wallet)!: Make Wallet require a change descriptor (valued mammal)

Pull request description:

  All `Wallet` constructors are modified to require a change descriptor, where previously it was optional. Additionally we enforce uniqueness of the change descriptor to avoid ambiguity when deriving scripts and ensure the wallet will always have two distinct keystores.

  Notable changes

  * Add error `DescriptorError::ExternalAndInternalAreTheSame`
  * Remove error `CreateTxError::ChangePolicyDescriptor`
  * No longer rely on `map_keychain`

  fixes #1383

  ### Notes to the reviewers

  ### Changelog notice

  Changed:

  Constructing a Wallet now requires two distinct descriptors.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

ACKs for top commit:
  notmandatory:
    re-ACK 8bc3d35f6c83d078551c4bc57f72f13324865486

Tree-SHA512: f0621deb7c4778f56c2ba744c70a54d813a

Run Details

99 of 114 new or added lines in 3 files covered. (86.84%)

1 existing line in 1 file now uncovered.

11253 of 13498 relevant lines covered (83.37%)

16529.36 hits per line