bitcoindevkit / bdk / 6884426202

84%

Build Type

push

github

Committed by notmandatory

Commit Message

Merge bitcoindevkit/bdk#1178: `LocalChain` with hardwired genesis block

f1b112e8f docs(bitcoind_rpc): update docs for `Emitter::new` (志宇)
9a250baf6 chore: make clippy happy (志宇)
79b84bed0 feat(bdk): changeset's `Append` impl checks that network is consistent (志宇)
06a956ad2 feat!: change `load_from_persistence` to return an option (志宇)
c3265e251 test(bdk): add tests for wallet constructor methods (志宇)
96f1d94e2 test(file_store): add construction method tests (志宇)
1886dc4fe chore(examples): use `Wallet::new_or_load` method where appropriate (志宇)
24994a3ed feat(file_store)!: have separate methods for creating and opening Store (志宇)
d294e2e31 feat(wallet)!: add `new_or_load` methods (志宇)
7c6cbc4d9 chore(file_store): rm empty test file (志宇)
6cf3963c6 feat(bdk)!: have separate methods for creating and loading `Wallet` (志宇)
7d5f31f6c feat(chain, file_store): add `is_empty` method to `PersistBackend` trait (志宇)
5998a2281 feat!: `LocalChain` with hardwired genesis checkpoint (志宇)

Pull request description:

  closes #1079
  closes #1107

  ### Description

  Many methods of `TxGraph` require a `chain_tip: BlockId` input to use against a `ChainOracle` implementation. This is used to ask the `ChainOracle` implementation whether a certain block exists in the chain identified by the `chain_tip`. This guarantees that the `TxGraph` methods will return a consistent history of transactions.

  However, the `ChainOracle` trait's `get_chain_tip` method returns an option of `BlockId`. It becomes unclear what to do when `get_chain_tip` returns `None`.

  This PR changes the `... (continued)

Run Details

338 of 486 new or added lines in 9 files covered. (69.55%)

45 existing lines in 10 files now uncovered.

8782 of 10810 relevant lines covered (81.24%)

5816.41 hits per line