bitcoindevkit / bdk / 12067428395

79%

push

github

Merge bitcoindevkit/bdk#1736: Sqlite - allow persisting anchor without tx

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/18f5f3fa21f5e83dab9e30a5f536e5526883d580">18f5f3fa2<a href="https://github.com/bitcoindevkit/bdk/commit/bf42562be7a9924aa83917a3339786d444509972"> test(sqlite): test persisting anchors and txs independently (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/297ff3414909ae42d34c31f5c942fc81aa1d60f9">297ff3414</a><a href="https://github.com/bitcoindevkit/bdk/commit/bf42562be7a9924aa83917a3339786d444509972"> test(chain): add test `insert_anchor_without_tx` (valued mammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/e69d10e7d387ffc96876b4290131d8fa9d4dd8ff">e69d10e7d</a><a href="https://github.com/bitcoindevkit/bdk/commit/bf42562be7a9924aa83917a3339786d444509972"> doc(chain): document module `rusqlite_impl` (valued mammal)
</a><a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/8fa899b74619b549e4880c28a0f1d348cb68f755">8fa899b74</a> fix(chain): Sqlite - allow persisting anchor without tx (志宇)

Pull request description:

  ### Description

  Previously, we may error when we insert an anchor where the txid being anchored has no corresponding tx.

  closes #1712
  replaces #961

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK 18f5f3fa21f5e83dab9e30a5f536e5526883d580
  ValuedMammal:
    ACK 18f5f3fa21f5e83dab9e30a5f536e5526883d580

Tree-SHA512: 7343eff85c36b8b430c9aa05c31d6a94b10

48 of 48 new or added lines in 1 file covered. (100.0%)

11617 of 13941 relevant lines covered (83.33%)

18538.37 hits per line