bitcoindevkit / bdk / 11945778645

79%

push

github

Merge bitcoindevkit/bdk#1732: chore(core)!: rename `SyncResult` to `SyncResponse`

<a class=hub.com/bitcoindevkit/bdk/commit/3b03c7bed2d132fbcdb027a8445f47f0b85d99fa">3b03c7bed<a href="https://github.com/bitcoindevkit/bdk/commit/d949fe4c73d8b56f255e1d4e72545651446b5313"> chore(core)!: rename `FullScanResult` to `FullScanResponse` (Leonardo Lima)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/1411cb8d58f669054c10c0dcfe67e6b271368544">1411cb8d5</a> chore(core)!: rename `SyncResult` to `SyncResponse` (Leonardo Lima)

Pull request description:

  fixes #1647

  <!-- You can erase any parts of this template not applicable to your Pull Request. -->

  ### Description

  As mentioned in #1647 issue, the usage of `Result` in Rust is conventionally meant to be an enum type with error variant, and it's appropriate here.

  It should be `SyncResponse` instead, as it's the most appropriate alongside the other types `SyncRequest` and `SyncProgress` already being used.

  <!-- Describe the purpose of this PR, what's being adding and/or fixed -->

  ### Notes to the reviewers

  <!-- In this section you can include notes directed to the reviewers, like explaining why some parts
  of the PR were done in a specific way -->

  ### Changelog notice

  <!-- Notice the release manager should include in the release tag message changelog -->
  <!-- See https://keepachangelog.com/en/1.0.0/ for examples -->

  - Change `bdk_core::spk_client`'s `SyncResult` to `SyncResponse`.

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### New Features:

  * [ ] I've added tests for the new feature
  * [ ] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [ ] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  notmandatory:
    reACK 3b03c7bed2d132fbcdb027a8445f47f0b85d99fa

Tree-SHA512: b18c44b739cab6490084edb38... (continued)

12 of 14 new or added lines in 4 files covered. (85.71%)

11501 of 13879 relevant lines covered (82.87%)

13934.13 hits per line