bitcoindevkit / bdk / 11573200391

79%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#1662: fix(wallet): fix building change signers in `load_with_params`

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/b6b767f3fc12062d6787eec8b3e1021458283985">b6b767f3f<a href="https://github.com/bitcoindevkit/bdk/commit/24097d7d8a5cebd828adfed21fe344ef3e358575"> test(wallet): check keymaps can be set when loading wallet (valued mammal)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/517fb53760626ada00551716fd35dbd84ed6d48e">517fb5376</a> fix(wallet): fix building change signers in `load_with_params` (valued mammal)

Pull request description:

  This fixes an issue that prevented change signers from being built when using the `keymap` method on `LoadParams`. Now we always build a `SignersContainer` with the internal keymap whenever a change descriptor is loaded. Note, the signer may still be "empty" if neither `keymap` or `extract_keys` is used.

  ### Notes to the reviewers

  Building a `SignersContainer` now happens outside of the [match statement](https://github.com/bitcoindevkit/bdk/blob/b6b767f3fc12062d6787eec8b3e1021458283985/crates/wallet/src/wallet/mod.rs#L557) in `load_with_params` which simplifies the logic such that we can interpret this area of code as "initialize a value for `change_descriptor` and optionally extend the internal keymap, returning a `LoadMismatch` error if the changeset doesn't match the expected params."

  ### Changelog notice

  ### Checklists

  #### All Submissions:

  * [x] I've signed all my commits
  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)
  * [x] I ran `cargo fmt` and `cargo clippy` before committing

  #### Bugfixes:

  * [x] I've added tests to reproduce the issue which are now passing

ACKs for top commit:
  evanlinjin:
    ACK b6b767f3fc12062d6787eec8b3e1021458283985

Tree-SHA512: fef2de691e9bd493b954e22a43c86f795e3

Run Details

10 of 10 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

11301 of 13680 relevant lines covered (82.61%)

15292.7 hits per line